Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jl/caip multichain/add api specs wallet create session #29592

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Jl/caip multichain/add api specs wallet create session #29592

merged 3 commits into from
Jan 8, 2025
+89 −21

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 8, 2025 •
edited by github-actions bot
Loading

Description

  • Add api-specs-multichain examples for wallet_createSession

Open in GitHub Codespaces

Related issues

See: https://github.com/MetaMask/MetaMask-planning/issues/3823
See: https://github.com/MetaMask/MetaMask-planning/issues/3824

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

adonesky1
adonesky1 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [cbd8b87]
Page Load Metrics (1810 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15842478181219694
domContentLoaded15742468178319292
load15852480181019493
domInteractive268338178
backgroundConnect1175312211
firstReactRender1676382412
getState55712157
initialActions01000
loadScripts10801939132716981
setupStore75816178
uiStartup17592727205420297

@jiexi jiexi marked this pull request as ready for review January 8, 2025 23:21
@jiexi jiexi merged commit 75814f4 into jl/caip-multichain-migrate-core Jan 8, 2025
73 of 76 checks passed
@jiexi jiexi deleted the jl/caip-multichain/add-api-specs-wallet-createSession branch January 8, 2025 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiexi @metamaskbot @adonesky1